Drop direct click imports to unblock typer upgrades#13
Open
debdutgoswami wants to merge 1 commit into
Open
Conversation
debdutgoswami
force-pushed
the
refactor/drop-click
branch
from
9df7d96 to
0333ce4
Compare
sharoonthomas
requested changes
Jun 2, 2026
Typer 0.26 vendored click privately as typer._click, so `import click` no longer resolves through typer's transitive dependency and external click handles stop sharing typer's Context thread-local. The previous workaround pinned typer below 0.26, which freezes the project on an older release line and blocks every future typer fix or feature.
debdutgoswami
force-pushed
the
refactor/drop-click
branch
from
0333ce4 to
2b56b90
Compare
Member
Author
|
@sharoonthomas can you review again? Made the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typer 0.26 vendored click privately as typer._click, so
import clickno longer resolves through typer's transitive dependency and external click handles stop sharing typer's Context thread-local. The previous workaround pinned typer below 0.26, which freezes the project on an older release line and blocks every future typer fix or feature.